1.78.0-insider breaks embedded terminal use of tty handoff

[ehagerty]

Type: Bug

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.78.0-insider
• OS Version: 13.4 Beta (22F5027f)
  Chip: Apple M1 Max
  Memory: 64 GB
  fish version 3.6.1
  TERM_PROGRAM=vscode
  TERM_PROGRAM_VERSION=1.78.0-insider
  TERM=xterm-256color
  SHELL=/opt/homebrew/bin/fish (this is a checked and valid path)

This report is meant to enhance the information provided in:
#178810
#178910

Steps to Reproduce:

1. try to open a fish shell in the integrated terminal

Result:
warning: No TTY for interactive shell (tcgetpgrp failed)
setpgid: Inappropriate ioctl for device

Notes:

1. terminal.integrated.shellIntegration.enabled can be set to either true or false with no effect
2. using an empty fish.config has no effect
3. having an empty settings.json has no effect
4. /opt/homebrew/bin/fish is a checked and valid path

The following comment fish-shell/fish-shell#9605 (comment) seems to suggest that in 1.77.0-insider and earlier, the launching of the integrated terminal must have been able to provide fish a valid tty upon checking stdin. Whatever changes were merged in 1.78.0-insider broke this behaviour.

It looks like there was a lot of work done on the embedded terminal for 1.78.0, so hopefully I'm on the right track here. 1.77.0...main

From a quick review of the code, I'd suggest looking at these three files:
cli/src/constants.rs (particularly the deletion of the old line 104)
cli/src/log.rs
cli/src/tunnels/singleton_client.rs (particularly the change to the old line 49)

NB other shells such as csh also warns of the problem but are able to cope, suggesting that whatever the regression was, it is probably worthy of a look.

I'm not a doctor, I only play one on television. If I have the wrong end of the stick here I apologise for the distraction.

VS Code version: Code - Insiders 1.78.0-insider (2da5a00, 2023-04-03T05:40:01.070Z)
OS version: Darwin arm64 22.5.0
Modes:
Sandboxed: Yes

System Info

Item	Value
CPUs	Apple M1 Max (10 x 24)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_renderer: enabled_on video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	4, 3, 4
Memory (System)	64.00GB (1.80GB free)
Process Argv	--crash-reporter-id 90140448-60a7-4040-90c1-9d4f366f64a9
Screen Reader	no
VM	0%

Extensions (34)

Extension	Author (truncated)	Version
better-comments	aar	3.0.2
better-toml	bun	0.3.2
dart-code	Dar	3.61.20230330
flutter	Dar	3.61.20230301
python-environment-manager	don	1.0.4
prettier-vscode	esb	9.10.4
esp-idf-extension	esp	1.6.0
cloudcode	goo	1.22.1-insiders.2
todo-tree	Gru	0.0.224
output-colorizer	IBM	0.1.2
vscode-circuitpython	joe	0.1.20
vscode-fix-checksums	leh	1.1.0
black-formatter	ms-	2023.1.10901017
isort	ms-	2023.9.10931010
pylint	ms-	2023.5.10901018
python	ms-	2023.7.10931008
vscode-pylance	ms-	2023.3.41
jupyter	ms-	2023.4.1000951011
jupyter-keymap	ms-	1.1.0
jupyter-renderers	ms-	1.0.15
vscode-jupyter-cell-tags	ms-	0.1.8
vscode-jupyter-slideshow	ms-	0.1.5
cmake-tools	ms-	1.14.23
cpptools	ms-	1.14.5
cpptools-extension-pack	ms-	1.3.0
color-highlight	nau	2.5.0
indent-rainbow	ode	8.3.1
material-icon-theme	PKi	4.25.0
vscode-commons	red	0.0.6
vscode-yaml	red	1.12.2
synthwave-vscode	Rob	0.1.15
vsc-workspace-sidebar	ske	1.4.2
fish-vscode	sky	0.2.1
vscodeintellicode	Vis	1.2.30

(1 theme extensions excluded)

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
nodejswelcome1:30587009
pyind779:30611226
pythonsymbol12:30651887
a9j8j154:30646983
showlangstatbar:30659908
pythonb192cf:30661257
azdwalk:30687957
pythonms35:30671666
cai9j608:30680470
7ij38806:30687742
pythonclientmv:30700173

[meganrogge]

/duplicate #178810