Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable transform optimization SettingsTree #179095

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Disable transform optimization SettingsTree #179095

merged 1 commit into from
Oct 2, 2023

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Apr 4, 2023 •
edited

Fix #177470

Disable transform optimization 馃槰

@rzhao271 rzhao271 added this to the May 2023 milestone Apr 10, 2023
@rzhao271 rzhao271 modified the milestones: May 2023, June 2023 May 30, 2023
@rzhao271 rzhao271 modified the milestones: June 2023, July 2023 Jun 26, 2023
@andreamah andreamah modified the milestones: July 2023, August 2023 Jul 26, 2023
@rzhao271 rzhao271 modified the milestones: August 2023, Backlog Aug 25, 2023
rzhao271
rzhao271 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this fixes the issue and that it's also used for some other editors such as the keybindings editor for a similar reason. Thanks!

@rzhao271 rzhao271 modified the milestones: Backlog, October 2023 Oct 2, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) October 2, 2023 18:31
@rzhao271 rzhao271 disabled auto-merge October 2, 2023 19:43
@rzhao271 rzhao271 closed this Oct 2, 2023
@rzhao271 rzhao271 reopened this Oct 2, 2023
@rzhao271 rzhao271 enabled auto-merge (squash) October 2, 2023 19:43
@rzhao271 rzhao271 merged commit b1bfdaa into microsoft:main Oct 2, 2023
5 of 6 checks passed
@tisilent tisilent deleted the #177470 branch October 2, 2023 21:57
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@tisilent @Alex0007
Disable transform optimization SettingsTree (microsoft#179095)
1d634ac
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@rzhao271 rzhao271

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

Bad UI
4 participants
@tisilent @Tyriar @rzhao271 @andreamah