Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progressive rendering issues #179432

Merged
merged 1 commit into from Apr 7, 2023
Merged

Fix progressive rendering issues #179432

merged 1 commit into from Apr 7, 2023

Conversation

roblourens
Copy link
Member

  • Tried to do progressive rendering while the view is hidden, this led to calling updateElementHeight with a height of 0 which apparently caused the list to not want to rerender that element later, so now we stop rendering when the view is not visible
  • Not restarting progressive rendering when revealing the view again
  • Restarting progressive rendering unnecessarily after completing it due to trying to cancel the timer before starting it

@roblourens
Fix progressive rendering issues
1cdf2b3 
- Tried to do progressive rendering while the view is hidden, this led to calling updateElementHeight with a height of 0 which apparently caused the list to not want to rerender that element later, so now we stop rendering when the view is not visible
- Not restarting progressive rendering when revealing the view again
- Restarting progressive rendering unnecessarily after completing it due to trying to cancel the timer before starting it
@roblourens roblourens enabled auto-merge (squash) April 7, 2023 00:23
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Apr 7, 2023
@roblourens roblourens merged commit ea0e3e0 into main Apr 7, 2023
8 checks passed
@roblourens roblourens deleted the roblou/stuck-camel branch April 7, 2023 03:18
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix rebornix approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roblourens @rebornix @VSCodeTriageBot