Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading window in zen mode goes into fullscreen mode without zen #18016

Closed
TheColorRed opened this issue Jan 2, 2017 · 3 comments
Closed
Assignees
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@TheColorRed
Copy link

TheColorRed commented Jan 2, 2017

  • VSCode Version: 1.8.1
  • OS Version: Ubuntu 16.10

Steps to Reproduce:

  1. Enter Zen Mode
  2. Press F1
  3. Search for and execute Reload Window
  4. You are now in full screen mode instead of zen mode

This causes the menu bar to disappear, and I could not figure out how to get it back because I didn't know I was in full screen mode instead of zen mode.

Basically it seems as if zen mode is getting turned off but fullscreen mode is not when the window is reloaded in zen mode.

@TheColorRed TheColorRed changed the title Reloading window in zen mode goes into full screen mode Reloading window in zen mode goes into fullscreen mode without zen Jan 2, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 3, 2017

Yes, we have decided that zen mode is not preserved across sessions. The reason for this is if somebody goes into zen mode and does not know how to get out of it - he can simply restart vscode.

Though I agree that this can be confusing that full screen and zen get out of sync - happens to me all the time.
So I propose that zen mode is preserved across vscode sessions.

@bpasero any suggestions maybe?

@isidorn isidorn added this to the January 2017 milestone Jan 3, 2017
@bpasero
Copy link
Member

bpasero commented Jan 3, 2017

Why not just preserve it when a window reload happens? We know if a reload happens vs. a restart (https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/workbench.ts#L798)

@isidorn
Copy link
Contributor

isidorn commented Jan 3, 2017

@bpasero good idea - I'll go with that

@isidorn isidorn added the verification-needed Verification of issue is requested label Jan 3, 2017
@isidorn isidorn closed this as completed in 7b663a4 Jan 3, 2017
@jrieken jrieken added the verified Verification succeeded label Jan 24, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants