Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change jsconfig.json "target" default value to "es2015" #18023

Closed
saschanaz opened this issue Jan 3, 2017 · 2 comments
Closed

Change jsconfig.json "target" default value to "es2015" #18023

saschanaz opened this issue Jan 3, 2017 · 2 comments
Assignees
Labels
javascript JavaScript support issues json JSON support issues

Comments

@saschanaz
Copy link

saschanaz commented Jan 3, 2017

  • VSCode Version: 1.8.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. Create a new empty jsconfig.json
  2. Write compilerOptions and target
  3. VSCode gives es6 by default whereas the name es2015 is now preferred
@mjbvz mjbvz self-assigned this Jan 3, 2017
@mjbvz mjbvz added javascript JavaScript support issues json JSON support issues labels Jan 3, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Jan 3, 2017

I'm going to move this issue over to schemastore, which is where we pick up the jsconfig.json schema. It should be as simple as updating this line: https://github.com/SchemaStore/schemastore/blob/master/src/schemas/json/jsconfig.json#L172

@saschanaz do you want to submit a PR against schemastore since you have more knowledge of this area?

Thanks

@mjbvz
Copy link
Contributor

mjbvz commented Jan 3, 2017

This issue was moved to SchemaStore/schemastore#262

@mjbvz mjbvz closed this as completed Jan 3, 2017
@dbaeumer dbaeumer removed their assignment Jan 9, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues json JSON support issues
Projects
None yet
Development

No branches or pull requests

3 participants