Organize Issue Services better #180432
Merged
Organize Issue Services better #180432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue services were due for a clean up. They now have this shape: * `platform/issue` has the `IssueMainService`, the service running on the Main process that Desktop takes advantage of * `workbench/contrib/issue` has the contributions and the registered commands * `workbench/services/issue` has the services that the renderer side can use to launch the issue reporter. After this, I will work on getting out the raw IPC calls in the IssueMainService.
mjbvz
approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue services were due for a clean up. They now have this shape:
platform/issuehas theIssueMainService, the service running on the Main process that Desktop takes advantage ofworkbench/contrib/issuehas the contributions and the registered commandsworkbench/services/issuehas the services that the renderer side can use to launch the issue reporter.After this, I will work on getting out the raw IPC calls in the IssueMainService.