Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE Theme PNG files broken when opening Welcome Screen in HTTPS with Docker when using VS Code Server #180853

Open
DJlee139 opened this issue Apr 25, 2023 · 4 comments
Assignees
Labels
help wanted Issues identified as good community contribution opportunities remote Remote system operations issues webview Webview issues
Milestone

Comments

@DJlee139
Copy link

Seeing failures to get the ide theme png files when on the welcome screen. When I test on my machine's localhost on http, everything seems to work fine but when testing on a docker container over https they fail to load. Everything else seems to be working fine aside from these, so I don't suspect it has something to do with my container or setup.

Steps to replicate:

Launch vs code over https
Go to welcome page
Select the theme tile (might need to select a different file first)
The other strange thing is that the other png files for other tiles seem to work so perhaps it's something with the extension that it pulls the themes from.

I've seen similar issues in coder's code-server which wraps vs code server
coder/code-server#4483 with the fix coder#16

So I suspect this is an issue in the vscode that can be resolved.

@lramos15 lramos15 assigned alexdima and unassigned lramos15 Apr 25, 2023
@alexdima alexdima assigned mjbvz and unassigned alexdima Apr 28, 2023
@alexdima alexdima added webview Webview issues remote Remote system operations issues labels Apr 28, 2023
@alexdima
Copy link
Member

alexdima commented Apr 28, 2023

@mjbvz Steps to get up and running on https:

  • launch the server e.g. from sources using ./scripts/code-server.sh
  • download caddy from https://caddyserver.com/v2
  • on macOS, the downloaded blob must be made executable and opened first via right click open
  • ./caddy_darwin_amd64 reverse-proxy --to localhost:8000
  • open https://localhost/?...

@DJlee139
Copy link
Author

@mjbvz @alexdima I'm able to see the png files when I run on my machine's localhost. However, I'm having issues viewing them when I run on a docker container's localhost. I also need to host the docker container on an aws ec2 instance for my use case so I'm unsure if that's also a layer that would affect this.

In my trial and error I found that by enabled "Bypass for network" for service workers in my chrome's dev tool application settings that the files do show correctly so it makes me suspect that there's something with how those service workers are being used that isn't playing nice with how I'm attempting to use VS Code Server right now. I've tried various methods through either Caddy or Apache to no success at this point.

@mjbvz
Copy link
Contributor

mjbvz commented May 1, 2023

I also don't see this locally:

Screenshot 2023-05-01 at 2 09 18 PM

@DJlee139 Do other webview based features work, such the built-in markdown preview?

@DJlee139
Copy link
Author

DJlee139 commented May 1, 2023

I'm unable to replicate it locally. I've only been able to see this when I run vs code server on localhost inside of a Docker container that is on an aws ec2 instance. Also other png files appear from the rest of the IDE. It's only those that are for theme that show.

Slightly unrelated, but for my case, is this something that I could replace the welcome page with? Ultimately, having this walkthrough appear isn't important for what I'm building, but having broken png's on my opening page when the IDE starts up is not ideal. I believe I've seen that I can build a vs code extension to have my own custom welcome page. Is that correct in assuming I could show my own walkthroughs instead. I wouldn't need this issue resolved if so.

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label Jul 18, 2023
@mjbvz mjbvz added this to the Backlog milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues identified as good community contribution opportunities remote Remote system operations issues webview Webview issues
Projects
None yet
Development

No branches or pull requests

4 participants