Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cursorHome and cursorEnd keybind for filter in problem view does not work if view is in bottom panel #180869

Open
zero41120 opened this issue Apr 25, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues
Milestone

Comments

@zero41120
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.78.0-insider (user setup)
Commit: 95396f1
Date: 2023-04-18T05:20:56.891Z
Electron: 22.4.5
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19045
Sandboxed: Yes

Steps to Reproduce:

  1. Drag problem view from left panel to bottom panel
  2. Focus the filter text input
  3. Enter some text
  4. Press "home" or "end" key, they are default keybinds for cursorHome and cursorEnd. Home does not place cursor to beginning. End does not place cursor to end, and also shift focus to "View as table"
  5. image
  6. Here is my key bindings for "end" key:
    image
@sandy081
Copy link
Member

End does not place cursor to end, and also shift focus to "View as table"

Seems it is navigating to the last element in the action bar. I do not know which component is eating this keybinding. Hence assigning to @ulugbekna to investigate.

@sandy081 sandy081 assigned ulugbekna and unassigned sandy081 May 11, 2023
@ulugbekna
Copy link
Contributor

@sandy081 the kb event isn't handled by this "filter" input box, so it's propagated to the ActionBar, which does something special on KeyCode.Home and KeyCode.End instead of letting the keybinding service handle the event. Isidor added this behavior in a13f7ee.

I would propose that we remove such special behavior for Home & End for ActionBar, but I'm not sure how many people are used to it

@sandy081
Copy link
Member

I would propose that we remove such special behavior for Home & End for ActionBar

This might break in other places where it works as expected. Instead it shall be implemented correctly just like how it is done for lists. Have a command and associate a keybinding.

@ulugbekna ulugbekna added bug Issue identified by VS Code Team member as probable bug error-list Problems view keybindings VS Code keybinding issues and removed error-list Problems view labels Dec 5, 2023
@ulugbekna ulugbekna added this to the Backlog milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues
Projects
None yet
Development

No branches or pull requests

3 participants