[typescript] Better paths matching for move to existing file quickpick #181231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
May 1, 2023
| const filename = Utils.basename(uri); | ||
|
|
||
| let description; | ||
| const filterQuery = ['./', '../'].find(str => quickPick.value.startsWith(str)); |
There was a problem hiding this comment.
On windows, paths will use \ instead. If possible though, it would be nice to support letting users type either ../ or ..\ on windows to access parent directories
There was a problem hiding this comment.
Yes, of course it is possible, not a big deal. Just didn't add support for it in the first place as never had to use \ in VS Code
| const quickPick = vscode.window.createQuickPick(); | ||
| const body = response.body; | ||
| const updateItems = () => { | ||
| const destinationItems = body.files.map((file): DestinationItem | undefined => { |
There was a problem hiding this comment.
This should be optimized to not compute anything if the user has not typed ./ or ../ to start the path
extensions/typescript-language-features/src/languageFeatures/refactor.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/refactor.ts
Show resolved
Hide resolved
use coalesce
|
By the way last time I tried it in insiders, I did see move to file code action (TS server didn't see interactive arg). Does it work on your end? Update: I see it also works in latest insiders, my bad |
mjbvz
approved these changes
Aug 9, 2023
Tyriar
approved these changes
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an improvement for #178535.
Moving statements to a sibling file is pretty common. In my case, I have nested file structure (5-6 levels deep) and it's hard to do this with current quickpick implementation, so I added simple filtering for
./and../values. Now it can be done much faster than with a native file picker.Summarized:
matchOnDescriptionshowQuickPicktocreateQuickPickAPI to implement relative path logic