feat: use custom tag instead of custom version for MS electron releases

[deepak1556]

Refs https://github.com/microsoft/vscode-electron-prebuilt/pull/24

[bpasero]

I am debating with myself if I should do a similar change for how we download node.js here:

vscode/build/gulpfile.reh.js

Lines 165 to 168 in 36b7d5b

	if (product.nodejsRepository) {
	return assetFromGithub(product.nodejsRepository, nodeVersion, name => name === `win-${arch}-node.exe`)
	.pipe(rename('node.exe'));
	}

However, what I find a bit strange is to have the msBuildNumber in our OSS sources and then only use it when electronRepository is defined in product.json.

I think a more elegant solution would be to encode repository and build number in the product.json, no?

[deepak1556]

Yeah I thought about that, but that approach makes it bit harder since we need to bump distro everytime the buildid changes. Additionally the current change keeps the version updates in the public repo for transparency.

[bpasero]

Fyi for node.js I am going with an approach where the version and checksums are part of the product.json:

https://github.com/microsoft/vscode/pull/184877/files#diff-285888428ebaab4e7985b695829cc9e47f98d2857505070ccacae3432b7b11dcR85-R88

[deepak1556]

Why not upload the Sha sums to release assets ex: https://github.com/electron/electron/releases/download/v25.1.0/SHASUMS256.txt and download from their for validation ? Also same for node.js https://github.com/nodejs/node#verifying-binaries

[deepak1556]

Sanity run: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=219010&view=results