Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

joh/dependent heron #181389

Merged
merged 8 commits into from May 3, 2023
Merged

joh/dependent heron #181389

merged 8 commits into from May 3, 2023

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented May 3, 2023

  • IE - move slash commands into widget, leaner controller, towards a more passive widget
  • make IE input widget more imperative, move input-promise logic into provider
  • enable diff revert commands for livePreview diff
  • allow for unlimited height of inline diff zone
  • move editMode logic into strategies, no more if-else 👯‍♂️
  • add missing super.dispose-call
  • enable/disable apply btn for preview mode
  • preview mode uses actual change ranges, and view hiding instead of model cropping

@jrieken jrieken self-assigned this May 3, 2023
@jrieken jrieken enabled auto-merge May 3, 2023 07:58
@VSCodeTriageBot VSCodeTriageBot added this to the May 2023 milestone May 3, 2023
@jrieken jrieken merged commit 09ebb50 into main May 3, 2023
7 checks passed
@jrieken jrieken deleted the joh/dependent-heron branch May 3, 2023 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero approved these changes

Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
May 2023
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrieken @bpasero @VSCodeTriageBot