New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot find module 'vscode-windows-ca-certs' #181404
Comments
By @deepak1556 @joaomoreno based on the error from #181400 (comment), looks like this commit microsoft/vscode-proxy-agent@f8fbc21 was not released and consumed in VSCode |
I assume this change was done in March and therefore it also exists in 1.77.0 ? |
Not sure why you're assuming the change was done in March. The change was done in April: 9008956. It's new in 1.78.0. This breaks automatic proxy discovery in the extension host on Windows platforms only. I don't think it's a stop ship because:
I suggest merging the fix in as a candidate of an April recovery milestone. Leaving it to you @sandy081, as endgame champ, to chime in. |
Because I saw the dependency on I agree to take this as a candidate for next recovery |
Just to clarify: This breaks loading of OS certificates on Windows (not proxy discovery). This will affect users relying on self-signed certificates for development and those requiring a CA certificate from their network proxy. Only HTTP/S requests made by extensions using the Node API are affected. |
Can a test get added to prevent this from happening again? |
@sandy081 This is also affecting remote-containers extension.
|
Thanks @joaomoreno Manually setting the proxy in remote settings worked for me |
Copied from #181400 (comment)
The text was updated successfully, but these errors were encountered: