Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipynb.pasteAsAttachment setting to default to editor.pasteAs.enabled behavior #181445

Merged
merged 3 commits into from May 10, 2023

Conversation

Yoyokrazy
Copy link
Contributor

This makes the paste as widget the defualt behavior for notebook markdown cells for images. If users choose to turn off editor.PasteAs.enabled then pasting as attachments will still work as intended. Currently, turning off ipynb.pasteImagesAsAttachments.enabled will remove all paste functionality in markdown cells.

@Yoyokrazy Yoyokrazy self-assigned this May 3, 2023
@Yoyokrazy Yoyokrazy enabled auto-merge (squash) May 3, 2023 19:43
@Yoyokrazy Yoyokrazy requested a review from rebornix May 3, 2023 19:43
@VSCodeTriageBot VSCodeTriageBot added this to the May 2023 milestone May 3, 2023
@Yoyokrazy
Copy link
Contributor Author

Reverted initial setting change. Only actual change is now to align the default value with what was defined in package.json.

The setting now acts an opt-out of attachment style pasting.

@Yoyokrazy Yoyokrazy merged commit 8867d20 into main May 10, 2023
7 checks passed
@Yoyokrazy Yoyokrazy deleted the relieved-damselfly branch May 10, 2023 00:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants