Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode Sets breakpoint in both sessions in multicore debugging with single Debug Configuration #181794

Open
asitsahoo351 opened this issue May 8, 2023 · 4 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@asitsahoo351
Copy link

In multicore debugging with a single debug configuration when we try setting breakpoints in either of the sessions it sets breakpoints for both of the debug sessions. For Example, Consider the Following case:

When we set a breakpoint in one Session which turns out to be an outbound breakpoint, then it tries to resolve the breakpoint to a random location in the other Debug Session, which results in an exception. So if we can stop setting breakpoint in both sessions and instead set them only in the user-requested session, we can overcome this problem.

@roblourens
Copy link
Member

What language? Adding a breakpoint always sets it in all debug sessions, but if it's not a valid location for some debug session that should be ignored.

@roblourens roblourens added the info-needed Issue requires more information from poster label May 12, 2023
@asitsahoo351
Copy link
Author

If we set breakpoint always in all debug sessions, It might create an issue in case of Disassemly Debugging. The location of the breakpoints is the Instructions Addresses in disassembly Debugging. The Instruction addresses of one Session might resolve with the Instruction address of another Session. Hence, it might hit the breakpoint in an unexpected location.

To resolve such conflicts, we can set them only in the user-requested session.

@roblourens
Copy link
Member

I think you're right and that could possibly be an issue, just looking at DAP, but we don't have a way to avoid this right now

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues and removed info-needed Issue requires more information from poster labels May 16, 2023
@roblourens roblourens added this to the Backlog milestone May 16, 2023
@connor4312
Copy link
Member

We would have to introduce the notion of session or config-specific breakpoints, which is a good idea but a bigger change

@connor4312 connor4312 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants