Refactor: softDispatch doesn't return null
#181891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulugbekna
commented
May 9, 2023
| @@ -953,7 +953,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { | |||
| // Respect chords if the allowChords setting is set and it's not Escape. Escape is | |||
| // handled specially for Zen Mode's Escape, Escape chord, plus it's important in | |||
| // terminals generally | |||
| const isValidChord = resolveResult?.kind === ResultKind.MoreChordsNeeded && this._configHelper.config.allowChords && event.key !== 'Escape'; | |||
| const isValidChord = resolveResult.kind === ResultKind.MoreChordsNeeded && this._configHelper.config.allowChords && event.key !== 'Escape'; | |||
There was a problem hiding this comment.
Hi @Tyriar
I refactored the keybindings resolver and, consequently, AbstractKeybindingService#softDispatch a bit in last iteration and propagated the changes to various parts of vscode that use the softDispatch. I introduced a regression in one such place and now trying to make sure my changes in other places make sense.
Would you mind confirming that what this line does matches the desired result? This particular PR doesn't do much, there's a more meaningful diff here - https://github.com/microsoft/vscode/pull/178699/files#
|
Seems fine, I think the only change that impacts me is that |
Tyriar
previously approved these changes
May 9, 2023
alexdima
approved these changes
May 12, 2023
Tyriar
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #181887
cc @roblourens @lramos15