Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For compare function add ability to DnD for file`s content into editor #182807

Closed
psnet opened this issue May 17, 2023 · 9 comments
Closed

For compare function add ability to DnD for file`s content into editor #182807

psnet opened this issue May 17, 2023 · 9 comments
Assignees
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality
Milestone

Comments

@psnet
Copy link

psnet commented May 17, 2023

зображення

Add ability to put contents of file using DnD to editor:

зображення

Now if you press shift it puts path of file into editor

зображення

@lramos15 lramos15 assigned mjbvz and unassigned lramos15 May 18, 2023
@mjbvz mjbvz assigned hediet and unassigned mjbvz May 18, 2023
@hediet
Copy link
Member

hediet commented May 22, 2023

@mjbvz I think you did some work on different drag&drop behaviors (insert path). What do you think of this feature?

Maybe it would be some "Hold [Ctrl] to compare with file"?

Code_-_Insiders_05YKuSo7V0

@hediet hediet added feature-request Request for new features or functionality diff-editor Diff editor issues labels May 22, 2023
@hediet hediet added this to the Backlog milestone May 22, 2023
@mjbvz
Copy link
Collaborator

mjbvz commented May 23, 2023

I personally would never use this feature. We also have drop to open and drop into, so I am not in favor of adding another way of dropping content without a very good use case

@psnet
Copy link
Author

psnet commented May 23, 2023

This is not about usage or not, this is basic fundamental feature that exists in many other IDEs: side-by-side diff for texts

@mjbvz
Copy link
Collaborator

mjbvz commented May 23, 2023

side-by-side diff for texts

yes and there are ways to do that already without dnd

@psnet
Copy link
Author

psnet commented May 23, 2023

ok, how to do this: one file from this project / git, one from another, I need compare them

@mjbvz
Copy link
Collaborator

mjbvz commented May 23, 2023

If both files are in the same project, select both in the explorer and use compare selected. Otherwise, you can use one of the Compare active file... commands, like compare active file with clipboard

Maybe we could add another way to compare files if there's a need, but DND doesn't seem like the correct UX

@mjbvz mjbvz closed this as completed May 23, 2023
@psnet
Copy link
Author

psnet commented May 23, 2023

Its first thing you think about to compare, DnD needed and is used in other also well-known IDE.

year ago when I requested this feature answer was also "it doesnt actual", but as we see it is added

@hediet
Copy link
Member

hediet commented May 24, 2023

This is not about usage or not, this is basic fundamental feature that exists in many other IDEs: side-by-side diff for texts

@psnet just for future reference, can you do research which editors/IDEs support this? (ideally share gifs)

IntelliJ does not seem to support this.

@psnet
Copy link
Author

psnet commented May 24, 2023

Full research dont have time, but exactly IntelliJ products have this functionality. Open command "open new diff window" and you will see side-by-side windows both accept DnD files into each side for comparison

@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
diff-editor Diff editor issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants