New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial share provider API and UI #182999
Conversation
@@ -154,7 +154,12 @@ export interface IPromptResultWithCancel<T> extends IPromptResult<T> { | |||
|
|||
export type IDialogResult = IConfirmationResult | IInputResult | IPromptResult<unknown>; | |||
|
|||
export type DialogType = 'none' | 'info' | 'error' | 'question' | 'warning'; | |||
export type DialogType = 'none' | 'info' | 'error' | 'question' | 'warning' | 'success'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bpasero this PR introduces a success/confirmation dialog to support a Share experience, given prior art in Powerpoint/Word, e.g.:
This also addresses a pain point where copy link actions today do not display success/confirmation and can fail silently. I would appreciate your review of the dialog-related changes here please--thank you!
I think clicking on share from command palette should directly open that dialog |
@abhijit-chikane yes, it does, I just didn't include that in the recording (the recording shows that Share... exists in the palette and that there is a button to access it which does the same thing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the introduction of a Success
severity strange tbh. I think the current values for Severity
make sense, but Success
is not a severity for me.
src/vs/workbench/contrib/files/electron-sandbox/fileActions.contribution.ts
Show resolved
Hide resolved
@bpasero would it help to rename |
I think severity is used in many contexts, but for dialogs specifically maybe something else should be used. Here is what Electron calls it: vscode/src/vs/base/parts/sandbox/common/electronTypes.ts Lines 19 to 25 in adbcbfa
|
@bpasero would it make sense for |
@joyceerhl can you talk with SteVen as component owner of custom dialogs? Maybe someone else took that over, not sure, he would know. |
For #176316
Introduces a share provider API and a top-level Share... command and icon in the command center toolbar. There's currently only one provider (from the builtin GitHub extension), more to come. Everything is hidden behind an unofficial setting
workbench.experimental.share.enabled
, demo:share.mp4
Screenshot: