Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Lines language definition #183035

Merged
merged 2 commits into from May 25, 2023
Merged

Add JSON Lines language definition #183035

merged 2 commits into from May 25, 2023

Conversation

DoctorKrolic
Copy link
Contributor

Part of #182402

This PR adds JSON Lines language definition with id jsonl. It doesn't add fancy language features, just basic colorization. But even this makes a great difference when viewing .jsonl files.

Looks like this:
Code_-_OSS_NcXK3eUR8q

Code_-_OSS_EPJlBdN13F

@DoctorKrolic
Copy link
Contributor Author

@microsoft-github-policy-service agree

@aeschli aeschli added this to the May 2023 milestone May 22, 2023
@aeschli aeschli requested a review from alexr00 May 22, 2023 09:17
@aeschli
Copy link
Contributor

aeschli commented May 22, 2023

Thanks a lot @DoctorKrolic ! Are you also looking at the language support? Otherwise that's something I can tackle.

alexr00
alexr00 previously approved these changes May 22, 2023
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

extensions/json/package.json Outdated Show resolved Hide resolved
@DoctorKrolic
Copy link
Contributor Author

Are you also looking at the language support?

Not really. TS isn't my primary language and this doesn't seem to be a trivial thing to do, since even parsing logic would require changes for it to work

@DoctorKrolic
Copy link
Contributor Author

CI is green. Merge?

@aeschli aeschli merged commit 0adddd8 into microsoft:main May 25, 2023
6 checks passed
@aeschli
Copy link
Contributor

aeschli commented May 25, 2023

Thanks @DoctorKrolic !

@DoctorKrolic DoctorKrolic deleted the add-jsonl-definition branch May 25, 2023 08:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants