Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embedder API for creating simple readonly terminals #183214

Merged
merged 3 commits into from May 23, 2023
Merged

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 23, 2023

cc @osortega

I tested by adding this into BrowserMain:

const onDidWriteEmitter = new Emitter<string>();
embedderTerminalService.createTerminal({
	name: 'Building Codespace',
	pty: {
		onDidWrite: onDidWriteEmitter.event,
		open() {
			onDidWriteEmitter.fire('Hello world!\r\n');
			setInterval(() => onDidWriteEmitter.fire('\r\nwork...'), 1000);
		},
		close() { },
	}
});

Recording 2023-05-23 at 06 09 50

@Tyriar Tyriar added this to the May 2023 milestone May 23, 2023
@Tyriar Tyriar requested a review from connor4312 May 23, 2023 13:21
@Tyriar Tyriar self-assigned this May 23, 2023
@Tyriar Tyriar merged commit da1049e into main May 23, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/embedder_api branch May 23, 2023 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants