Getting started page awaits a lifecycle phase in setInput?

[bpasero]

(found this because this actually resulted in a error: #183226)

Code is here:

vscode/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts

Line 308 in bf9be2c

await this.lifecycleService.when(LifecyclePhase.Restored);

I do not fully understand this, but instead of awaiting the phase in setInput, why not await it before opening the welcome page? And why does not wait at all there, what is the reason?

I think this may also be the cause of #181660

[bhavyaus]

My bad. I wasn't aware that the ContextKeyHandler was also using the EditorInput to performs checks.
My main goal with introducing that check in #182947 was to check for all service ready before I attempted to fetch content for the welcome page.

I think this may also be the cause of #181660

This was a change I introduced last Friday and #181660 precedes it. I've already fixed the issue with: #182796

[bpasero]

My main goal was to check for all service ready before I attempted to fetch content for the welcome page.

Can you clarify what "all services ready" means for example?