Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the typescript quick fixes #183425

Merged
merged 3 commits into from May 25, 2023
Merged

Polishing the typescript quick fixes #183425

merged 3 commits into from May 25, 2023

Conversation

aiday-mar
Copy link
Contributor

Changes from second review of #183215

@aiday-mar aiday-mar self-assigned this May 25, 2023
@aiday-mar aiday-mar requested a review from jrieken May 25, 2023 12:49
@VSCodeTriageBot VSCodeTriageBot added this to the May 2023 milestone May 25, 2023
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but also add a comment to the setting that it requires "a extension" to work

@jrieken jrieken requested a review from mjbvz May 25, 2023 13:53
@aiday-mar aiday-mar merged commit fdf6802 into main May 25, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/polishingQuickFixes branch May 25, 2023 14:32
@aiday-mar
Copy link
Contributor Author

Hey @mjbvz, sorry it's the second time I merge a PR without your review (I should be more mindful of this, I do it a bit automatically when I see someone has approved). Please let me know if there is anything I can change to make the code better.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants