Support for Notebook CodeAction Kind
#183457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
previously requested changes
May 25, 2023
rzhao271
approved these changes
May 26, 2023
| // https://github.com/microsoft/vscode/issues/179213 | ||
|
|
||
| export class NotebookCodeActionKind { | ||
| // can only return MULTI CELL workspaceEdits |
There was a problem hiding this comment.
Debt: could the comment be a docstring?
| @@ -152,6 +154,9 @@ class CodeActionOnSaveParticipant implements IStoredFileWorkingCopySaveParticipa | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #179213
Add in proposed api for the new CodeActionKind of
NotebookFormally support notebook codeactions on save for ipynb notebook files. Notebook Save Participants first call the providers for the first cell of the notebook, running all notebook specific actions across the entire notebook. Once they resolve, providers are called for all cells in the notebook, performing source level actions on each cell in parallel.
As stated in the proposed api, any CodeAction with the
Notebookwill only be called for the first cell of the notebook, and all CodeActions not with that kind must only apply edits to the single cell that they are passed.