Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering of 'Problems' Tab when Reverting or Adding Files via Git Commands #183509

Closed
larisafe opened this issue May 26, 2023 · 6 comments
Closed
Assignees
Labels
info-needed Issue requires more information from poster

Comments

@larisafe
Copy link

larisafe commented May 26, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.78.2
  • OS Version: Windoss 10 Enterprise

Steps to Reproduce:

  1. Make changes to a few files in your project, introducing issues or errors that would be displayed in the "Problems" tab of Visual Studio Code.
  2. Revert the changes made in Step 1 using Git or perform any other Git operation, such as stashing or adding the changes.
  3. After reverting the changes, observe the "Problems" tab. When files are reverted problems tab starts flickering which can be seen on the attached gif below.

flickering

Tasks

No tasks being tracked yet.
@sandy081
Copy link
Member

sandy081 commented Jun 1, 2023

When files are reverted problems tab starts flickering which can be seen on the attached gif below.

Do you mean the number being reduced and finally disappearing?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jun 1, 2023
@larisafe
Copy link
Author

larisafe commented Jun 1, 2023

Yes, the number jumped a few times before disappeared. In our case, we have a file watcher responsible for handling numerous files within our system. Whenever a file undergoes a change, we consistently invoke the function VsCodeManager.updateDiagnosticCollection to update the problems tab accordingly. Unfortunately, the rapid and frequent changes have resulted in an irritating issue, resembling a flickering effect, when there is a really big number of files changed. This problem has persisted for the past month or so and it came with the new version of vs code, as it was not present prior to that. So I am guessing that probably the rendering of problems was somehow changed recently.

@sandy081
Copy link
Member

sandy081 commented Jun 1, 2023

Interesting, can you please let us know the last version of VS Code it is working as expected? Can you also please share the gif?

@larisafe
Copy link
Author

larisafe commented Jun 2, 2023

I think that the problem started when we upgrade vs code engine version from 1.52.0 to 1.74.0.
I am sending you another gif of how flickering looks like when VsCodeManager.updateDiagnosticCollection is called frequently, for a large amount of changed files. The problem is the same as on the gif above, but the above diagnostic collections were not updated so frequently so flickering may not be so visible.

flickering_newVersion

@sandy081
Copy link
Member

sandy081 commented Jun 7, 2023

I think that the problem started when we upgrade vs code engine version from 1.52.0 to 1.74.0.

Can I presume that you do not see this behaviour before 1.52.0 ?

@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants