Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PortAutoForwardAction's opening commands not working #183850

Closed
andreamah opened this issue May 30, 2023 · 2 comments · Fixed by #184412 or #184418
Closed

PortAutoForwardAction's opening commands not working #183850

andreamah opened this issue May 30, 2023 · 2 comments · Fixed by #184412 or #184418
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release remote-explorer Remote explorer view verified Verification succeeded
Milestone

Comments

@andreamah
Copy link
Contributor

Testing #183547

When I try to return PortAutoForwardAction.OpenPreview, PortAutoForwardAction.OpenBrowser, and PortAutoForwardAction.OpenBrowserOnce aren't working for me.

  1. Create an extension as described in registerPortAttributesProvider({portRange:[5000,5000]}... doesn't match port 5000 #183846 and create a ports attribute provider.
  2. Use the following to return one of the above actions:
	providePortAttributes(
		port: number,
		pid: number | undefined,
		commandLine: string | undefined,
		token: vscode.CancellationToken
	): vscode.ProviderResult<vscode.PortAttributes> {
			return new vscode.PortAttributes(
				<insert non-functioning action from above>
			);
	}
  1. When running the command, we just get a notification. 🐛

I'm not sure whether this is happening because I'm in a devcontainer.

@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug remote-explorer Remote explorer view labels May 31, 2023
@alexr00 alexr00 added this to the June 2023 milestone May 31, 2023
@alexr00 alexr00 added the candidate Issue identified as probable candidate for fixing in the next release label Jun 6, 2023
@alexr00 alexr00 modified the milestones: June 2023, May 2023 Jun 6, 2023
@andreamah
Copy link
Contributor Author

Hmm, I'm still seeing this in an alpine devcontainer. The previews/browsers should open immediately upon detection, right?

@andreamah
Copy link
Contributor Author

Verified using different verif steps than above.

@andreamah andreamah added the verified Verification succeeded label Jun 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release remote-explorer Remote explorer view verified Verification succeeded
Projects
None yet
2 participants