Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Insider "Reload Window" restarts terminal. #183911

Closed
olafurw opened this issue May 31, 2023 · 8 comments
Closed

VSCode Insider "Reload Window" restarts terminal. #183911

olafurw opened this issue May 31, 2023 · 8 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@olafurw
Copy link

olafurw commented May 31, 2023

Type: Bug

In the normal version of VSCode, if I have an application running in the built in terminal and do any kind of plugin update or even just do "Developer: Reload Window" the application stays open.

But in the Insider version the application closes because it seems it's reloading the terminal.

VS Code version: Code - Insiders 1.79.0-insider (fa8eefd, 2023-05-31T03:06:45.096Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 1805)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.73GB (7.68GB free)
Process Argv --crash-reporter-id 0396c3e3-f3f7-42d3-b730-cbcae8243f2d
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
vscode-eslint dba 2.4.0
gitlens eam 2023.5.3005
EditorConfig Edi 0.16.4
prettier-vscode esb 9.13.0
copilot-chat Git 0.1.2023053001
copilot-labs Git 0.14.884
copilot-nightly Git 1.87.129
vscode-typescript-next ms- 5.2.20230530
svelte-vscode sve 107.5.1
pretty-ts-errors yoa 0.4.1
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
vsc_aacf:30263846
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
pythonsymbol12:30651887
showlangstatbar:30737417
pythonms35:30671666
19089226:30680468
ecj1e332:30687743
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30724385
showsbindicator:30724477
pythongtdpath:30726887

@meganrogge
Copy link
Contributor

Please provide a gif illustrating the problem
/label info-needed terminal

@VSCodeTriageBot VSCodeTriageBot added info-needed Issue requires more information from poster terminal Integrated terminal issues labels May 31, 2023
@olafurw
Copy link
Author

olafurw commented May 31, 2023

Made a video.

https://www.youtube.com/watch?v=qSCN4hsakeg

@meganrogge
Copy link
Contributor

Thanks for the video. I am not seeing that repro in insider's 🤔 . Could you pls provide me with your settings.json file? There was a recent regression with terminal reconnection that was fixed with #183516

Screen.Recording.2023-05-31.at.3.56.56.PM.mov

@olafurw
Copy link
Author

olafurw commented May 31, 2023

What settings.json ? If from the project, there is none. This was the sveltekit starter project.

If you mean the VSCode settings. Where can I get that? This was a fresh install of VSCode Insiders in this machine. I originally had the issue on my work laptop but never installed Insiders on this home machine.

@meganrogge
Copy link
Contributor

@Tyriar can you reproduce?

@VSCodeTriageBot
Copy link
Collaborator

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@VSCodeTriageBot VSCodeTriageBot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@olafurw
Copy link
Author

olafurw commented Jul 13, 2023

It's weird that you close the issue ticket like this without any communication.

Anyway, it does not happen anymore on the latest version of insider. So thanks, I guess?
Also I don't see anything about this auto closing if nobody does anything in your issue reporting guidelines, so maybe update that.

@Tyriar
Copy link
Member

Tyriar commented Jul 13, 2023

@olafurw the bot closed it because it had been over a week with the info-needed label and the last comment was from a team member. This was my fault as I'm way behind on notifications, it also should not have had the info-needed label.

Regardless, glad to hear you're not seeing it anymore.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

4 participants