Polish query accepting #183995
Merged
Polish query accepting #183995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut. Fixes microsoft/vscode-internalbacklog#4286 Also, when we open in chat, we should use the last accepted query, not what's in the input box. Fixes microsoft/vscode-internalbacklog#4280
Tyriar
approved these changes
May 31, 2023
| @@ -93,8 +94,9 @@ class AskQuickQuestionAction extends Action2 { | |||
| }); | |||
| disposableStore.add(openInChat); | |||
| disposableStore.add(openInChat.onChange(async () => { | |||
| await this._currentSession?.openInChat(this._input!.value); | |||
| await this._currentSession?.openInChat(this._lastAcceptedQuery ?? this._input!.value); | |||
There was a problem hiding this comment.
You could avoid the ! if you set a input variable to the outer function scope
There was a problem hiding this comment.
will add in debt week
| @@ -249,10 +253,13 @@ class InteractiveQuickPickSession extends Disposable { | |||
|
|
|||
| async accept(query: string) { | |||
| await this._model.waitForInitialization(); | |||
| const requests = this._model.getRequests(); | |||
| const lastRequest = requests[requests.length - 1]; | |||
| if (lastRequest?.message && lastRequest?.message === query) { | |||
There was a problem hiding this comment.
The lastRequest?.message condition is redundant
There was a problem hiding this comment.
will add in debt week
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't send the same request to Copilot if the query hasn't changed. So if the query is the same, we short circut.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4286
Also, when we open in chat, we should use the last accepted query, not what's in the input box.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/4280