Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change welcome dialog contribution to Eventually #184005

Merged
merged 1 commit into from Jun 1, 2023
Merged

Conversation

bhavyaus
Copy link
Contributor

@bhavyaus bhavyaus commented Jun 1, 2023

Fixes issue with Welcome Dialog not being rendered.

Addresses: #183658

We control the dialogs visibility through an experimental setting.

const setting = configurationService.getValue<boolean>(configurationKey);

This experimental setting is set after the check above happens.

const value = await this.workbenchAssignmentService.getTreatment(`config.${property}`);
if (!isUndefined(value) && !equals(value, schema.default)) {

Delaying this contribution initialization to Eventually as a fix.

@meganrogge meganrogge merged commit c386785 into main Jun 1, 2023
6 checks passed
@meganrogge meganrogge deleted the dev/bhavyau/welcome branch June 1, 2023 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants