Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use undo-loop instead of undo-edit when discarding chat session #184063

Merged
merged 2 commits into from Jun 1, 2023

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Jun 1, 2023

@jrieken jrieken self-assigned this Jun 1, 2023
@jrieken jrieken enabled auto-merge (squash) June 1, 2023 13:23
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged in June as testing has already happened?

@jrieken
Copy link
Member Author

jrieken commented Jun 1, 2023

@Tyriar still fixing bugs today

@Tyriar
Copy link
Member

Tyriar commented Jun 1, 2023

@jrieken it was reported 3 weeks ago though. We've been trying to improve endgame by reducing the amount of changes that go in post testing to increase stability, endgame quality/testing has been a big topic of discussion on our end at least. It's up to you as you understand the severity/risk more

@jrieken jrieken merged commit ce729a5 into main Jun 1, 2023
6 checks passed
@jrieken jrieken deleted the joh/local-mink branch June 1, 2023 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants