Fix usage of types coming outside of TS base lib & allow embedders to intercept TT calls also in the worker #184148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexr00
approved these changes
Jun 2, 2023
jaylinski
reviewed
Jun 6, 2023
| */ | ||
| createTrustedTypesPolicy<Options extends TrustedTypePolicyOptions>( | ||
| createTrustedTypesPolicy( |
There was a problem hiding this comment.
@alexdima Shouldn't this method be optional? createTrustedTypesPolicy?()
Because of this change, Monaco Editor 0.39 requires this method to be implemented when creating a new environment:
https://microsoft.github.io/monaco-editor/docs.html#interfaces/Environment.html
This "breaks" type-checking in some Monaco Editor examples:
Error: Property 'createTrustedTypesPolicy' is missing in type '{ getWorkerUrl: (_workerId: string, label: string) => string; }' but required in type 'Environment'. (ts)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.