allow images in markdown preview editor to be copied #184432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Looks like a good start. Left some feedback. let me know if you have any questions about it
Regarding:
If the preview editor is not clicked on before copying, no new information will be copied to the clipboard.
Did you figure out causes this? Is there some way we can fix it?
extensions/markdown-language-features/src/commands/showPreview.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/commands/showPreview.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/commands/showPreview.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/preview/previewManager.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/commands/showPreview.ts
Outdated
Show resolved
Hide resolved
mjbvz
requested changes
Jun 6, 2023
extensions/markdown-language-features/src/commands/showPreview.ts
Outdated
Show resolved
Hide resolved
extensions/markdown-language-features/src/preview/previewManager.ts
Outdated
Show resolved
Hide resolved
mjbvz
requested changes
Jun 7, 2023
extensions/markdown-language-features/src/preview/previewManager.ts
Outdated
Show resolved
Hide resolved
mjbvz
approved these changes
Jun 7, 2023
lramos15
approved these changes
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an image in a markdown file's preview editor is right clicked, there is a new "Copy" button that allows you to copy from the preview editor and paste to the markdown file. This works in all cases when the preview editor tab is highlighted and focused. If the preview editor is not clicked on before copying, no new information will be copied to the clipboard.