Spawning the interactive editor widget with left indentation #184480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
reviewed
Jun 8, 2023
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts
Outdated
Show resolved
Hide resolved
jrieken
reviewed
Jun 9, 2023
jrieken
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-copilot/issues/289
The code is structured in such a way so that the inline chat widget appears at the indentation level of the first valid line (not containing only whitespaces) above it. By default the indentation will be used, unless there is little available space in the editor (less than 400px) in which case the inline chat will be shown at the left most position with no indentation.
Screen.Recording.2023-06-08.at.16.52.00.mov