Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt editor resolver for Welcome/Walkthrough pages #184770

Merged
merged 2 commits into from Jun 11, 2023

Conversation

bhavyaus
Copy link
Contributor

@bhavyaus bhavyaus commented Jun 9, 2023

Addresses:
#166831

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool!

I would suggest to tackle #184673 here as well because depending on where the input is contributed, we may need to move it to an earlier phase. Specifically the editor resolver needs to know about the registration before we attempt to open the welcome page from layout.ts I think.

@bhavyaus
Copy link
Contributor Author

This is very cool!

I would suggest to tackle #184673 here as well because depending on where the input is contributed, we may need to move it to an earlier phase. Specifically the editor resolver needs to know about the registration before we attempt to open the welcome page from layout.ts I think.

I'll tackle this in separate PR. I might have to move some of startup logic to an earlier phase as well. I want to keep this change specific to adopting the editor resolver.

@bhavyaus bhavyaus requested a review from bpasero June 11, 2023 17:34
@bhavyaus bhavyaus merged commit ef6abe4 into main Jun 11, 2023
6 checks passed
@bhavyaus bhavyaus deleted the dev/bhavyau/getting-started-editor branch June 11, 2023 20:37
@abhijit-chikane
Copy link
Contributor

abhijit-chikane commented Jun 14, 2023

I think any tab open over there after closing should be able to get it after pressing CTRL+SHIFT+T
I was going over the release notes and I accidently closed it but after click CTRL+SHIFT+T it didn't open
same for the extension tabs If I click on any extension and close the tab after CTRL+SHIFT+T it should open it
also notice this behaviour in thunder client extension contributed tab.
image

I think any close tab should be undoable irrespective of the type of tab
@bhavyaus @bpasero

@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants