New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable app sandbox when --no-sandbox is present #184897
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have expected us to simply go strict for --no-sandbox
and not introduce a new thing --sandbox
to keep the change small and match our expected args.
@bpasero it is not possible to rely on the boolean attribute of vscode/src/vs/platform/environment/node/argv.ts Lines 170 to 175 in 46041c9
sandbox to no-sandbox , so this PR does not introduce a new flag. It works like this,
|
Thanks! |
* fix: disable app sandbox when --no-sandbox is present (#184897) * fix: loading minimist in packaged builds
Refs #184687