prevent screen reader from reading a user's chat request on enter #185153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested on Windows and discussed this with @rperez030 |
roblourens
reviewed
Jun 14, 2023
connor4312
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/microsoft/vscode-internalbacklog/issues/4181
cc @jooyoungseo, @rperez030
Since a user has just typed their input, we don't want a screen reader to read it when enter is pressed. This is also important to fix as it blocks the progress audio cue that we will have as an option.
Unblocks https://github.com/microsoft/vscode-copilot/issues/197