Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider the request to allow modals in Simple Browser and other WebViews #185204

Open
gjsjohnmurray opened this issue Jun 15, 2023 · 6 comments
Open

Reconsider the request to allow modals in Simple Browser and other WebViews #185204

gjsjohnmurray opened this issue Jun 15, 2023 · 6 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality webview Webview issues
Milestone
Backlog

Comments

@gjsjohnmurray
Copy link
Contributor

@mjbvz graciously accepted my recent PR #185117 to make webview-hosted pages able to download files. This means Simple Browser can now do a better job of hosting a legacy web app that is important to users of several of my extensions. But that web app still chokes whenever the user takes a path leading to a window.alert() or window.confirm(). There is little prospect of the web app being changed to use <dialog> instead.

Back in 2019 @GordonSmith unsuccessfully requested allow-modals. Please reconsider this.
@gjsjohnmurray gjsjohnmurray mentioned this issue Jun 15, 2023
Merged
@mjbvz mjbvz added feature-request Request for new features or functionality webview Webview issues labels Jun 19, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the Backlog Candidates milestone Jun 19, 2023
@VSCodeTriageBot
Copy link
Collaborator

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@gjsjohnmurray
Copy link
Contributor Author

@mjbvz would you consider a PR for this even without the 20 upvotes?

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 19, 2023

Not yet as I'd like to gauge interest first. Even if we get 20+ upvotes though we may decide not to support this

@gjsjohnmurray gjsjohnmurray mentioned this issue Jun 24, 2023
Open
@VSCodeTriageBot
Copy link
Collaborator

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@framalho
Copy link

framalho commented Aug 9, 2023

20 now!

@VSCodeTriageBot
Copy link
Collaborator

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 31, 2023
Closed
@dotNomad dotNomad mentioned this issue Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality webview Webview issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@gjsjohnmurray @mjbvz @framalho @VSCodeTriageBot