Making zone widget background same as selection if inside of the selection #185241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185122
The current implementation of the zone widget makes the zone widget appear always to the left of the vertical scrollbar, which caused the blue background not to extend to behind the scrollbar. The code has been changed so as to allow the zone widget to be behind the vertical scrollbar.
In order to account for the gutter on the left which should not be colored in blue, the fixed margin is set on the zone container. This way the inline chat widget left margin is only based on the indentation width. This has allowed to simplify the code.
Screen.Recording.2023-06-15.at.17.44.53.mov