Reduce unnecessary calls to PtyService #185389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not change through the runtime of the pty host Fixes #185379
meganrogge
reviewed
Jun 20, 2023
| }); | ||
| } | ||
|
|
||
| resize(cols: number, rows: number): void { | ||
| if (this._inReplay) { | ||
| if (this._inReplay || this._lastDimensions.cols === cols && this._lastDimensions.rows === rows) { |
There was a problem hiding this comment.
hmm, will keep my eye out for issues, i wonder if this could go wrong
There was a problem hiding this comment.
Since there should only ever be a single window attached, it should stay in sync
meganrogge
approved these changes
Jun 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up profile resolving/terminal startup:
PtyService.getEnvironmentis only called a single time as the value shouldn't changePtyService.resizeis never called using the same args consecutively (per terminal)Part of #133542
Fixes #185379