Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #182014: ISO Date format #185587

Merged

Conversation

rielAsh24
Copy link
Contributor

@rielAsh24 rielAsh24 commented Jun 19, 2023

Fixes #182014

This change addresses the date formatting on the Extensions page to align with ISO-8601 (yyyy/mm/dd).

Sample Output:

ISO_format

@gjsjohnmurray
Copy link
Contributor

#182014 (comment)

@sandy081
Copy link
Member

@rielAsh24 As per @gjsjohnmurray's comment, can you please change the separator

Based on https://en.wikipedia.org/wiki/ISO_8601 the separators should be - rather than /

@rielAsh24
Copy link
Contributor Author

@rielAsh24 As per @gjsjohnmurray's comment, can you please change the separator

Based on https://en.wikipedia.org/wiki/ISO_8601 the separators should be - rather than /

Sure! Will implement the changes as you suggested

@rielAsh24 rielAsh24 force-pushed the rielAsh24/issue-182014-ISO_Dates branch from e2c2420 to 5d7b23f Compare June 20, 2023 10:27
@rielAsh24
Copy link
Contributor Author

rielAsh24 commented Jun 20, 2023

@sandy081 Added the - :

ISO_format

@rielAsh24 rielAsh24 force-pushed the rielAsh24/issue-182014-ISO_Dates branch from 9a00106 to 208b692 Compare June 20, 2023 16:09
@rielAsh24 rielAsh24 force-pushed the rielAsh24/issue-182014-ISO_Dates branch 2 times, most recently from 037aecd to 332483f Compare June 23, 2023 14:24
ISO Date reconstruction for Locale

Migrated from toISOStrings to prevent UTC Dates returned

Updated Date format

Added yyyy-mm-dd format in Extensions Info
@rielAsh24 rielAsh24 force-pushed the rielAsh24/issue-182014-ISO_Dates branch from 332483f to 96fba00 Compare June 26, 2023 18:21
@rielAsh24
Copy link
Contributor Author

Hey @sandy081, are there any other changes required to complete this PR?

@rielAsh24 rielAsh24 changed the title Updated Date format Fix #182014: ISO Date format Jun 28, 2023
@sandy081 sandy081 added this to the July 2023 milestone Jul 4, 2023
@sandy081 sandy081 enabled auto-merge July 4, 2023 13:25
@sandy081 sandy081 merged commit 36f8388 into microsoft:main Jul 4, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show ISO format dates always
4 participants