Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make terminals stats section in perfviewEditor #185754

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Make terminals stats section in perfviewEditor #185754

merged 6 commits into from
Jun 21, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 21, 2023

Part of #185393

image

@Tyriar Tyriar added this to the June 2023 milestone Jun 21, 2023
@Tyriar Tyriar requested a review from jrieken June 21, 2023 11:40
@Tyriar Tyriar self-assigned this Jun 21, 2023
@Tyriar Tyriar enabled auto-merge June 21, 2023 11:40
@Tyriar
Copy link
Member Author

Tyriar commented Jun 21, 2023

I made the changes, it required a bunch of shuffling around of "terminal backends" to move them into platform so they could be used in the timer service. In the big ed54d72 commit the main point of interest is the change in timerService.ts

Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfEditor and timerService changes are looking good (didn't check the other ;-))

@Tyriar Tyriar merged commit 8af267c into main Jun 21, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/185393_2 branch June 21, 2023 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants