Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask user to commit/push changes when copying links #185802

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Ask user to commit/push changes when copying links #185802

merged 2 commits into from
Jun 21, 2023

Conversation

joyceerhl
Copy link
Contributor

Fixes #177793

@joyceerhl joyceerhl enabled auto-merge (squash) June 21, 2023 18:36
@joyceerhl joyceerhl self-assigned this Jun 21, 2023
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 21, 2023
rzhao271
rzhao271 reviewed Jun 21, 2023
View reviewed changes
Copy link
Contributor

@rzhao271 rzhao271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that cancellation errors are thrown, is there anything to catch those errors, especially for provideShare?

@joyceerhl
Copy link
Contributor Author

Cancellation errors thrown on the ext host side are ignored for provideShare, but the gutter link actions don't go through provideShare and those would've been surfaced with a showErrorMessage, nice catch

@joyceerhl joyceerhl merged commit 31478ce into main Jun 21, 2023
6 checks passed
@joyceerhl joyceerhl deleted the dev/joyceerhl/skilled-barracuda branch June 21, 2023 22:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 left review comments

@mjbvz mjbvz mjbvz approved these changes

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Copy links to vscode.dev & GitHub are shown for files that don't exist on that remote repo
4 participants
@joyceerhl @rzhao271 @mjbvz @VSCodeTriageBot