fix: snap env variables leaking into terminal env #185834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
robo/fix_snap_env
branch
from
a4c6cac
to
46cea0a
Compare
joaomoreno
approved these changes
Jun 22, 2023
AmeyaVS
reviewed
Jul 12, 2023
| for (const key in process.env) { | ||
| if (key.endsWith('_VSCODE_SNAP_ORIG')) { | ||
| const originalKey = key.slice(0, -17); // Remove the _VSCODE_SNAP_ORIG suffix | ||
| if (this._snapEnv[originalKey]) { |
There was a problem hiding this comment.
This seems suspicious.
Is it checking the _snapEnv[originalKey] is empty or not?
If it is not empty then it will skip the the complete loop logic following it.
There was a problem hiding this comment.
_snapEnv[originalKey] will not be defined when this function gets called, this is only present when multiple unsetSnapExportedVariables() calls are made without calling to restoreSnapExportedVariables(), which does not happen today.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179917
Fixes #179086