events: improve emitter performance

[connor4312]

This saves about 10ms off our startup time with high probability (p=0.0002).

Closes #185789

[jrieken]

nit: privates use _ in this file, no use of public unless needed

[jrieken]

Nice stuff 👏

Maybe add a test that ensures adjusting the delivery "queue" works when compactation occurs during delivery. This is and the whole private delivery mechanism is definitly under-tested

[jrieken]

This saves about 10ms off our startup time with high probability

Out of curiosity: what kind of machine has been used? Can you check the dev tools log for a message like this: "INFO [perf] Render performance baseline is 18ms". Would allow us to guess the real world impact

[connor4312]

Maybe add a test that ensures adjusting the delivery "queue" works when compactation occurs during delivery. This is and the whole private delivery mechanism is definitly under-tested

that's tested by the "dispose during emission" test 🙂

Out of curiosity: what kind of machine has been used? Can you check the dev tools log for a message like this: "INFO [perf] Render performance baseline is 18ms". Would allow us to guess the real world impact

This is on my desktop PC (Windows, nvidia 3080, amd ryzen 5900X) which has a renderer baseline around ~25ms.

[connor4312]

Looked through the tests and ran event.test.ts with coverage. It looks like we have good coverage with the existing suite; we have complete line and branch coverage except for the leakageMon and unreachable branches. I added a couple more tests, but if you see any angles I missed please let me know!