Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing incorrect indent #185986

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fixing incorrect indent #185986

merged 2 commits into from
Jun 23, 2023

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jun 23, 2023

Fixes #185973

Previously showWidget was called twice, now it is called three times. The second call should take in initialRender = true.

There appeared to be a second error related to the needsMargin() function which was sending the wrong boolean. The negation of the boolean had to be sent.

@aiday-mar aiday-mar self-assigned this Jun 23, 2023
@aiday-mar aiday-mar requested a review from jrieken June 23, 2023 12:43
@aiday-mar aiday-mar marked this pull request as ready for review June 23, 2023 12:43
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 23, 2023
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@jrieken
Copy link
Member

jrieken commented Jun 23, 2023

Previously showWidget was called twice, now it is called three times.

Sorry, I might have caused this issue

@aiday-mar
Copy link
Contributor Author

No worries

@aiday-mar aiday-mar enabled auto-merge June 23, 2023 12:54
@aiday-mar aiday-mar merged commit d72845c into main Jun 23, 2023
6 checks passed
@aiday-mar aiday-mar deleted the aiday/incorrectIndentation branch June 23, 2023 13:01
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline chat: sudden incorrect indent
3 participants