feat: provide disable-chromium-sandbox runtime argument #186004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpasero
requested changes
Jun 23, 2023
src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
Outdated
Show resolved
Hide resolved
bpasero
reviewed
Jun 23, 2023
src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
Outdated
Show resolved
Hide resolved
bpasero
reviewed
Jun 24, 2023
There was a problem hiding this comment.
If I can make a suggestion: lets drop the changes that trigger a restart dialog for argv.json from this PR. Users that are impacted of the sandbox issue already need to start VS Code with --no-sandbox to even be able to start it and its fine for them to leave VS Code running even after changing argv.json. Asking them to restart again is a strange experience I would argue.
src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts
Outdated
Show resolved
Hide resolved
bpasero
approved these changes
Jun 26, 2023
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jun 26, 2023
…6004) * feat: provide disable-chromium-sandbox runtime argument * chore: address review feedback * chore: remove relaunch prompt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #184687 (comment)
Users should now be able to persist their sandbox preference via,