fix: remove emulation check and notification on windows #186008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
approved these changes
Jun 23, 2023
auto-merge was automatically disabled
June 26, 2023 02:16
Pull request was closed
gjsjohnmurray
pushed a commit
to gjsjohnmurray/vscode
that referenced
this pull request
Jun 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.runningUnderARM64Translationwill return incorrect value on windows since the API currently checks the machine architecture rather than if the process is a WoW process, refs https://github.com/electron/electron/blob/9226cc662b9c6cf3404d59c50cae0f0ccc1a0a0d/shell/browser/api/electron_api_app.cc#L1492-L1496. Removing the check on windows to avoid false notifications.