Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve profiles on main in parallel #186033

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Resolve profiles on main in parallel #186033

merged 1 commit into from
Jun 23, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 23, 2023

Part of #185393

This actually makes getProfiles fast enough on my macbook that by the time createTerminal is called for reconnecting terminals the profiles are already available 馃帀, so it no longer shows up in the terminal startup stats!

Before 801ms

2023-06-23 14:25:19.783 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:19.783 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:19.783 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:19.783 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.117 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.117 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.120 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.120 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.224 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.224 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.225 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.225 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.293 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.293 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.296 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.296 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.364 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.364 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.384 [trace] menubarService#updateMenubar 1
2023-06-23 14:25:20.388 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.388 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.477 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.477 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.502 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.518 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.557 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.557 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.563 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:25:20.563 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:25:20.589 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:25:20.589 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:25:20.590 [trace] transformToTerminalProfiles validate profile paths done

After 187ms

2023-06-23 14:43:52.154 [trace] transformToTerminalProfiles
2023-06-23 14:43:52.154 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.154 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.154 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.155 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.156 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.156 [trace] transformToTerminalProfiles variableResolver
2023-06-23 14:43:52.314 [trace] [UtilityProcess id: 1, type: extensionHost, pid: <none>]: creating new...
2023-06-23 14:43:52.317 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.317 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.318 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.319 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.319 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.319 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.319 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.320 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.320 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.320 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.321 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.321 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.321 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.321 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.322 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.322 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.322 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.323 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.323 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.323 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.324 [trace] transformToTerminalProfiles variableResolver done
2023-06-23 14:43:52.324 [trace] transformToTerminalProfiles validate profile paths
2023-06-23 14:43:52.325 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.325 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.325 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.325 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.328 [trace] [UtilityProcess id: 1, type: extensionHost, pid: 8838]: successfully created
2023-06-23 14:43:52.329 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.330 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.339 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.340 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.340 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.340 [trace] transformToTerminalProfiles validate profile paths done
2023-06-23 14:43:52.341 [trace] transformToTerminalProfiles validate profile paths done

@Tyriar Tyriar added this to the June 2023 milestone Jun 23, 2023
@Tyriar Tyriar requested a review from meganrogge June 23, 2023 21:52
@Tyriar Tyriar self-assigned this Jun 23, 2023
@Tyriar Tyriar enabled auto-merge June 23, 2023 21:54
meganrogge
meganrogge approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憦馃徏

@Tyriar Tyriar merged commit 2bd04a1 into main Jun 23, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/185393_3 branch June 23, 2023 22:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tyriar @meganrogge