Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up terminal reconnection #186072

Merged
merged 11 commits into from
Jun 26, 2023
Merged

Speed up terminal reconnection #186072

merged 11 commits into from
Jun 26, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 24, 2023

Summary:

  • Terminals are all re-created synchronously, this speeds up reconnection a little, but the biggest win here is the user should see all the restored terminals appear all at once instead of trickling in
  • Added replay terminal stats
  • Remove orphan check when attaching to processes (> 50% speed of replay)
    • Before (10 terminals): willReplay -> didReplay
      • Run 1: 7504ms
      • Run 2: 7495ms
    • After (10 terminals): willReplay -> didReplay
      • Run 1: 3433ms
      • Run 2: 3545ms
  • The removal of the orphan check may fix Reattached to the wrong terminal #133542, I want to verify more before closing that though

Fixes #186068
Fixes #186069
Part of #185393
Part of #133542

@Tyriar Tyriar added this to the June 2023 milestone Jun 24, 2023
@Tyriar Tyriar merged commit e2fcf63 into main Jun 26, 2023
6 checks passed
@Tyriar Tyriar deleted the tyriar/185393_5 branch June 26, 2023 19:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants