Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LocalPty onto the direct proxy #186083

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Move LocalPty onto the direct proxy #186083

merged 1 commit into from
Jun 26, 2023

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 24, 2023

Fixes #186070

I measured calls to LocalPty.input which went from ~1.2ms to ~0.6ms

@Tyriar Tyriar added this to the June 2023 milestone Jun 24, 2023
@Tyriar Tyriar requested a review from meganrogge June 24, 2023 20:30
@Tyriar Tyriar self-assigned this Jun 24, 2023
@Tyriar Tyriar enabled auto-merge June 24, 2023 20:30
@Tyriar Tyriar merged commit ef4cd64 into main Jun 26, 2023
7 checks passed
@Tyriar Tyriar deleted the tyriar/186070 branch June 26, 2023 16:22
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meganrogge meganrogge meganrogge approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

LocalPty object does not use the direct proxy to the pty host
2 participants
@Tyriar @meganrogge