Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML comment tags break Markdown list indentation #186232

Closed
RokeJulianLockhart opened this issue Jun 26, 2023 · 4 comments
Closed

HTML comment tags break Markdown list indentation #186232

RokeJulianLockhart opened this issue Jun 26, 2023 · 4 comments
Assignees
Labels
*as-designed Described behavior is as designed markdown Markdown support issues

Comments

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jun 26, 2023

Does this issue occur when all extensions are disabled?: Yes

  1. VS Code Version

    rokejulianlockhart@RQN6C6:~> code-insiders -v
    1.80.0-insider
    49b8e2d5410795e5a23a9c6b7f99b97f4afb4b47
    x64
    rokejulianlockhart@RQN6C6:~>
    
  2. OS Version

    rokejulianlockhart@RQN6C6:~> uname -a
    Linux RQN6C6 6.3.9-1-default #1 SMP PREEMPT_DYNAMIC Thu Jun 22 03:53:43 UTC 2023 (0df701d) x86_64 x86_64 x86_64 GNU/Linux
    rokejulianlockhart@RQN6C6:~>
    
  3. Steps to Reproduce

    0. placeholder
    
        text
    
    0. placeholder
    
        text
    
    0. placeholder
    
        text
    
        0. placeholder
    
            text
    
        0. placeholder
    
            text
    
        0. placeholder
    
            text
    
            0. placeholder
    
                text
    
            0. placeholder
    
                text
    
            0. placeholder
    
                text
    
    0. placeholder
    
        text
    
    <!--
    
    0. placeholder
    
        text
    
    -->
    
    0. placeholder
    
        text
    
        0. placeholder
    
            text
    
        <!--
    
        0. placeholder
    
            text
    
        -->
    
        0. placeholder
    
            text
    
            0. placeholder
    
                text
    
            <!--
    
            0. placeholder
    
                text
    
            -->
    
            0. placeholder
    
                text

    (scroll) produces

    image

    which is obviously wrong.

  4. Origin

    Due to Nested automatically numbered (0.) lists don't render more than one level deep. #184429 (comment), reported at HTML comment tags break Markdown list indentation markdown-it/markdown-it#942 (comment). Close if unnecessary to track here.

@mjbvz
Copy link
Contributor

mjbvz commented Jun 26, 2023

This matches how the common mark spec implementation renders it

If you feel this incorrect, please follow up with Common mark

@mjbvz mjbvz closed this as completed Jun 26, 2023
@mjbvz mjbvz added markdown Markdown support issues *as-designed Described behavior is as designed labels Jun 26, 2023
@RokeJulianLockhart
Copy link
Author

RokeJulianLockhart commented Jun 27, 2023

This matches how the common mark spec implementation renders it

https://talk.commonmark.org/t/html-comment-tags-break-markdown-list-indentation/4459?u=rokejulianlockhart

If you feel this incorrect, please follow up with Common mark

@mjbvz, probably best to close as not planned then, right?

@vassudanagunta
Copy link

This isn't a CommonMark or Markdown-it bug. See https://talk.commonmark.org/t/html-comment-tags-break-markdown-list-indentation/4459/2?u=vas

@RokeJulianLockhart
Copy link
Author

@vassudanagunta, that comment merely states that current CommonMark HTML comment tag support is basic. Considering the obvious formatting issues with no evident benefit to their continued existence, I have, per the instruction stated within that response, filed this as an issue at commonmark/commonmark-spec#741 (comment).

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed markdown Markdown support issues
Projects
None yet
Development

No branches or pull requests

3 participants