Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialogs - validate and normalize default path #186467

Merged
merged 2 commits into from
Jun 28, 2023
Merged

dialogs - validate and normalize default path #186467

merged 2 commits into from
Jun 28, 2023

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Jun 28, 2023 •
edited

fix #186297
fix #186295

@bpasero bpasero enabled auto-merge (squash) June 28, 2023 05:57
@bpasero bpasero requested a review from alexr00 June 28, 2023 05:57
@VSCodeTriageBot VSCodeTriageBot added this to the June 2023 milestone Jun 28, 2023
@bpasero bpasero requested a review from alexr00 June 28, 2023 10:04
alexr00
alexr00 approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bpasero bpasero merged commit fb1d792 into main Jun 28, 2023
6 checks passed
@bpasero bpasero deleted the ben/competent-penguin branch June 28, 2023 10:31
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Inconsistencies with relative default path Simple file dialog doesn't validate nonsense default path
3 participants
@bpasero @alexr00 @VSCodeTriageBot